Skip to content
This repository was archived by the owner on Sep 18, 2017. It is now read-only.

fix: allow any code change to generate at least a "patch" version#13

Open
pensierinmusica wants to merge 1 commit into
semantic-release:masterfrom
pensierinmusica:master
Open

fix: allow any code change to generate at least a "patch" version#13
pensierinmusica wants to merge 1 commit into
semantic-release:masterfrom
pensierinmusica:master

Conversation

@pensierinmusica

Copy link
Copy Markdown

Whenever a code change is published, with any commit message, it should at least generate a new "patch" version.

closes semantic-release/commit-analyzer#12

@pensierinmusica

Copy link
Copy Markdown
Author

Hi @boennemann did you have any chance to take a look at this?

Comment thread src/index.js
if (commit.type === 'feat') type = 'minor'

if (!type && commit.type === 'fix') type = 'patch'
if (!type) type = 'patch'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to avoid the version going up if a contributor's commit message does not adhere to a specific format.

@pensierinmusica

Copy link
Copy Markdown
Author

@rodoabad I initially was thinking along the same lines, then I read all the threads linked here and I realized that it's actually more desirable to have at least a patch version far any new commits being pushed.

Another way to look at it is that the responsibility to enforce a specific commit format is not within semantic-release scope, but rather the responsibility of libraries like commitizen.

Most importantly though, the summary of the semver threads linked in the comment above is that any change in the public version (no matter if it's docs, test, build tools, etc.) requires at least a new patch version.

This imho should be the default behaviour, then users could always pass different config parameters to the plugin, once a new version supports them as described here: semantic-release/commit-analyzer#3

@wilmoore

wilmoore commented Apr 5, 2016

Copy link
Copy Markdown

👍

@hutson

hutson commented Apr 7, 2016

Copy link
Copy Markdown

As per #11 I think @boennemann should deprecate commit-analyzer and migrate to conventional-recommended-bump.

@pensierinmusica

Copy link
Copy Markdown
Author

@hbetts that's an option, would conventional-recommended-bump always suggest at least a patch upgrade if there are any new pushed commits?

@LeonardoGentile

Copy link
Copy Markdown

Any news on this?
One year of silence on this suggest me that this repo is unmaintained ?

@ayanozturk

Copy link
Copy Markdown

Any news on this?

@LeonardoGentile

Copy link
Copy Markdown

@ayanozturk I'm using this: https://github.com/elliotttf/semantic-release-conventional-commits so I can configure what kind of commit triggers what kind of release

@frank-dspeed

Copy link
Copy Markdown

Conclusion

@ALL this repo is not maintained any more you need to do custom versions of sematic-release for your usecases

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants